Hello,
as far as I have seen in the most recent source code on GitHub, neither the EngineID, nor the EngineBoots value can be set from an external entity. One could help oneself changing the EngineID by using reflection on the private readonly member ``EngineGroup._engineId`` but EngineBoots gets calculated in the ``EngineGroup.EngineTimeData`` property. As far as I understand, the calculation returns zero until 24 days have been passed since the application's start-up. I'm sorry, but this looks pretty randomly chosen to me. According to RFC 3414, each application start-up should increase the EngineBoots value by one or use Int32.MaxValue if EngineBoots cannot be determined.
Could you please clarify the behaviour of your implementation? Will the behaviour change with the next NuGet release of the library?
Thanks in advance,
Kristian Virkus
Comments: Pull requests are welcome at GitHub, but a few things to note, * Configurable out of the box is quite difficult to define. Someone wants to store it in code, while others might want to leave it in a config file/registry key/other place. Thus, the PR should not stick to a single implementation. * The NuGet version is for manager side development mainly. Any agent side development should clone the source code and get started from there. In that case, there is less a need to make such attributes configurable, as anyway the code is going to be modified.
as far as I have seen in the most recent source code on GitHub, neither the EngineID, nor the EngineBoots value can be set from an external entity. One could help oneself changing the EngineID by using reflection on the private readonly member ``EngineGroup._engineId`` but EngineBoots gets calculated in the ``EngineGroup.EngineTimeData`` property. As far as I understand, the calculation returns zero until 24 days have been passed since the application's start-up. I'm sorry, but this looks pretty randomly chosen to me. According to RFC 3414, each application start-up should increase the EngineBoots value by one or use Int32.MaxValue if EngineBoots cannot be determined.
Could you please clarify the behaviour of your implementation? Will the behaviour change with the next NuGet release of the library?
Thanks in advance,
Kristian Virkus
Comments: Pull requests are welcome at GitHub, but a few things to note, * Configurable out of the box is quite difficult to define. Someone wants to store it in code, while others might want to leave it in a config file/registry key/other place. Thus, the PR should not stick to a single implementation. * The NuGet version is for manager side development mainly. Any agent side development should clone the source code and get started from there. In that case, there is less a need to make such attributes configurable, as anyway the code is going to be modified.